:fix add image_file_name column on attendees table #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vuefes-2024 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jiyuujin
reviewed
Jul 6, 2024
supabase/schema.sql
Outdated
| @@ -88,6 +88,8 @@ create table if not exists public.attendees ( | |||
| updated_at timestamp with time zone default timezone('utc' :: text, now()) not null | |||
| ); | |||
|
|
|||
| ALTER TABLE public.attendees ADD COLUMN image_file_name varchar(100) not null unique; | |||
There was a problem hiding this comment.
@jiyuujin
確かにそうですね。
以下のような形で、uuidを生成する形で問題ないでしょうか？
ALTER TABLE public.attendees ADD COLUMN image_file_name uuid not null unique default uuid_generate_v4();
There was a problem hiding this comment.
上記内容で修正した内容をpushしています。
ファイルダウンロード時に、${image_file_name}.jpg のような形になると思いますので
ファイル名はユニークであれば適当に生成しちゃって良いと理解しました。間違っていたらすいません。
There was a problem hiding this comment.
良いと思います、ユニークにしていただいていれば画像を特定できるはずですので問題無いかと
|
ご確認ありがとうございます。 |
|
supabase に反映しました。 |
|
@jiyuujin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#Issue
https://vuejs-jp.slack.com/archives/C0679DDM1EX/p1720232169741139?thread_ts=1719322838.997179&cid=C0679DDM1EX
#Details
https://github.com/vuejs-jp/vuefes-2024-backside/issues/207